[webkit-reviews] review granted: [Bug 124537] Build script should fail when any invalid option is passed to it : [Attachment 217233] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 124537: Build script should fail when any invalid option is passed to it
https://bugs.webkit.org/show_bug.cgi?id=124537

Attachment 217233: Patch
https://bugs.webkit.org/attachment.cgi?id=217233&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217233&action=review


> Tools/ChangeLog:10
> +	   It pass through command-line options only for xcode builds as it

s/xcode/Xcode/

> Tools/ChangeLog:12
> +	   E.g: Tools/Scripts/build-webkit ARCHS="x86 ppc"

It's actually i386, I think-o'd before. This is an antique example anyway, so
it doesn't really matter.

> Tools/ChangeLog:15
> +

I confirmed that this still works fine with Xcode.