[webkit-reviews] review granted: [Bug 124528] Add PageLoadState class : [Attachment 217215] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 124528: Add PageLoadState class
https://bugs.webkit.org/show_bug.cgi?id=124528

Attachment 217215: Patch
https://bugs.webkit.org/attachment.cgi?id=217215&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217215&action=review


Looks OK.

> Source/WebKit2/ChangeLog:10
> +	   Trying to use the main frame load state as the page load state was a
bad idea,
> +	   add a new PageLoadState and use it instead. Ultimately the long term
plan is to
> +	   transition away from FrameLoadState entirely.

FrameLoadState was just recently added? Should we revert those patches if they
were steps in the wrong direction?

> Source/WebKit2/UIProcess/PageLoadState.h:41
> +private:
> +

Please remove this.