[webkit-reviews] review granted: [Bug 124522] Add quirk for old positioning behavior : [Attachment 217209] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 124522: Add quirk for old positioning behavior
https://bugs.webkit.org/show_bug.cgi?id=124522

Attachment 217209: Patch
https://bugs.webkit.org/attachment.cgi?id=217209&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217209&action=review


> Source/WebCore/ChangeLog:8
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   No new tests (OOPS!).

OOPS!

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2269
> +    if (textAlign == TASTART ||
document().settings()->useLegacyTextAlignPositionedElementBehavior()) // FIXME:
Handle TAEND here

Please add a comment referencing a bug here, so we know sometime in future
whether we can remove it, and possibly stating the last Safari version that
shipped with the legacy behavior.