[webkit-reviews] review granted: [Bug 124429] Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate sidebar and content views : [Attachment 217070] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 124429: Web Inspector: Add TreeOutlineDataGridSynchronizer to coordinate
sidebar and content views
https://bugs.webkit.org/show_bug.cgi?id=124429

Attachment 217070: Patch
https://bugs.webkit.org/attachment.cgi?id=217070&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217070&action=review


r=me

> Source/WebInspectorUI/UserInterface/TreeOutlineDataGridSynchronizer.js:60
> +    treeOutline.onremove = function(element) {
> +	   this._treeElementRemoved(element);
> +	   if (existingOnRemove)
> +	       existingOnRemove.call(treeOutline, element);
> +    }.bind(this);

Based on the naming for all of these, I would expect the "this.method" to be
called after the existing TreeOutline method. But no strong reason to change
now.