[webkit-reviews] review granted: [Bug 124367] [ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code : [Attachment 216954] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 124367: [ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient
code
https://bugs.webkit.org/show_bug.cgi?id=124367

Attachment 216954: Patch
https://bugs.webkit.org/attachment.cgi?id=216954&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216954&action=review


Anders may know more about the history of this code.

It would be very much worth it to delete as much as possible.

> Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp:-45
> -    if (!m_download)
> -	   return;
> -    m_download->useCredential(challenge, credential);

Please add a fixme referencing https://bugs.webkit.org/show_bug.cgi?id=119667

// FIXME (119667): This can probably be just removed.

> Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp:-52
> -    if (!m_download)
> -	   return;
> -    m_download->continueWithoutCredential(challenge);

Ditto.

> Source/WebKit2/Shared/Downloads/DownloadAuthenticationClient.cpp:-59
> -    if (!m_download)
> -	   return;
> -    m_download->cancelAuthenticationChallenge(challenge);

Ditto.