[webkit-reviews] review denied: [Bug 122676] build.webkit.org/dashboard should provide a way to focus on a subset of bots : [Attachment 217026] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 08:29:16 PST 2013


Timothy Hatcher <timothy at apple.com> has denied Tim Horton <thorton at apple.com>'s
request for review:
Bug 122676: build.webkit.org/dashboard should provide a way to focus on a
subset of bots
https://bugs.webkit.org/show_bug.cgi?id=122676

Attachment 217026: patch
https://bugs.webkit.org/attachment.cgi?id=217026&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217026&action=review


Otherwise looks good.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/S
ettings.js:74
> +    applyHiddenPlatforms: function()

It seems odd to have this here. It touches stuff only the main script should.


More information about the webkit-reviews mailing list