[webkit-reviews] review requested: [Bug 124401] [EFL] Leak in ewk_frame_certificate_status_get() : [Attachment 217043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 05:18:57 PST 2013


Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 124401: [EFL] Leak in ewk_frame_certificate_status_get()
https://bugs.webkit.org/show_bug.cgi?id=124401

Attachment 217043: Patch
https://bugs.webkit.org/attachment.cgi?id=217043&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
(In reply to comment #4)
> I think you could even avoid to create the soup message object by simply
using
>
> if (documentLoader->request().soupMessageFlags() &
SOUP_MESSAGE_CERTIFICATE_TRUSTED)

Good point, here's the new patch.


More information about the webkit-reviews mailing list