[webkit-reviews] review requested: [Bug 124153] [EFL] Fix several warnings for ARM cross compilation : [Attachment 217042] Fix for ARM warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 04:38:30 PST 2013


Gabor Rapcsanyi <rgabor at webkit.org> has asked  for review:
Bug 124153: [EFL] Fix several warnings for ARM cross compilation
https://bugs.webkit.org/show_bug.cgi?id=124153

Attachment 217042: Fix for ARM warnings
https://bugs.webkit.org/attachment.cgi?id=217042&action=review

------- Additional Comments from Gabor Rapcsanyi <rgabor at webkit.org>
This patch fixes all of the warnings. Mostly I changed some reinterpret_cast to
reinterpret_cast_ptr and add some UNUSED_PARAM macro.
There was a strange warning here:
WebMemorySamplerLinux.cpp:70:19: warning: comparison is always false due to
limited range of data type
As I found out on ARM architecture the char type is unsigned by default and
this caused the problem. I changed that to signed char.


More information about the webkit-reviews mailing list