[webkit-reviews] review canceled: [Bug 124153] [EFL] Fix several warnings for ARM cross compilation : [Attachment 216581] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 15 04:38:29 PST 2013


Gabor Rapcsanyi <rgabor at webkit.org> has canceled Gabor Rapcsanyi
<rgabor at webkit.org>'s request for review:
Bug 124153: [EFL] Fix several warnings for ARM cross compilation
https://bugs.webkit.org/show_bug.cgi?id=124153

Attachment 216581: proposed patch
https://bugs.webkit.org/attachment.cgi?id=216581&action=review

------- Additional Comments from Gabor Rapcsanyi <rgabor at webkit.org>
This patch fixes all of the warnings. Mostly I changed some reinterpret_cast to
reinterpret_cast_ptr and add some UNUSED_PARAM macro.
There was a strange warning here:
WebMemorySamplerLinux.cpp:70:19: warning: comparison is always false due to
limited range of data type
As I found out on ARM architecture the char type is unsigned by default and
this caused the problem. I changed that to signed char.


More information about the webkit-reviews mailing list