[webkit-reviews] review granted: [Bug 123821] -dealloc callbacks from wrapped Objective-C objects can happen at bad times : [Attachment 216989] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 123821: -dealloc callbacks from wrapped Objective-C objects can happen at
bad times
https://bugs.webkit.org/show_bug.cgi?id=123821

Attachment 216989: Patch
https://bugs.webkit.org/attachment.cgi?id=216989&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216989&action=review


> Source/JavaScriptCore/API/APIShims.h:86
> +	   : m_dropAllLocks(shouldDropAllLocks(exec->vm()) ? exec : 0)

nullptr

> Source/JavaScriptCore/API/APIShims.h:93
> +	   : m_dropAllLocks(shouldDropAllLocks(vm) ? &vm : 0)

nullptr

> Source/JavaScriptCore/API/ObjCCallbackFunction.mm:411
>	   // We need to explicity release the target since we didn't call 

Missing an "l" in explicitly. Should probably grep for this typo. I think I’ve
seen it elsewhere too.

> Source/JavaScriptCore/API/ObjCCallbackFunction.mm:524
> +    ObjCCallbackFunction* function = jsCast<ObjCCallbackFunction*>(cell);

I’d use a reference for the local variable since it’s never null.