[webkit-reviews] review granted: [Bug 124380] [Win] Improve support for command line build of 64-bit JSC : [Attachment 216981] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 124380: [Win] Improve support for command line build of 64-bit JSC
https://bugs.webkit.org/show_bug.cgi?id=124380

Attachment 216981: Patch
https://bugs.webkit.org/attachment.cgi?id=216981&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216981&action=review


r=me!

> Tools/Scripts/webkitdirs.pm:377
> +    push(@args, '--debug') if ($configuration =~ "Debug");
> +    push(@args, '--release') if ($configuration =~ "Release");

Nit:  Maybe match on "^Debug" and "^Release"  Or do you want other (less valid)
things to work as well?