[webkit-reviews] review granted: [Bug 124369] Modifying RTCIceCandidate object construction to match the spec : [Attachment 216958] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 14 15:25:30 PST 2013


Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 124369: Modifying RTCIceCandidate object construction to match the spec
https://bugs.webkit.org/show_bug.cgi?id=124369

Attachment 216958: Patch
https://bugs.webkit.org/attachment.cgi?id=216958&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216958&action=review


> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:67
> +    ok = dictionary.get("sdpMLineIndex", tempLineIndex);
> +    // Then we try to convert it to a number and check if it was successful.

> +    unsigned short sdpMLineIndex =
tempLineIndex.toUIntStrict(&intConversionOk);
> +    if (ok && !intConversionOk) {

Nit: there isn't any reason to attempt the conversion to int if the key doesn't
exist.


More information about the webkit-reviews mailing list