[webkit-reviews] review granted: [Bug 124379] Reimplement getDayBoundaries using NSCalendar : [Attachment 216975] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 124379: Reimplement getDayBoundaries using NSCalendar
https://bugs.webkit.org/show_bug.cgi?id=124379

Attachment 216975: Patch
https://bugs.webkit.org/attachment.cgi?id=216975&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216975&action=review


> Source/WebKit/mac/History/WebHistory.mm:158
> +    NSCalendar *calendar = [NSCalendar
calendarWithIdentifier:NSCalendarIdentifierGregorian];

I believe NSCalendarIdentifierGregorian and NSCalendarUnitDay aren’t available
in some of the SDKs we target. You may need to add #ifdefs around some things
here.