[webkit-reviews] review denied: [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities : [Attachment 216943] v1.2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 124325: Consolidate and expose Frame/Node/Selection screenshot capabilities
https://bugs.webkit.org/show_bug.cgi?id=124325

Attachment 216943: v1.2
https://bugs.webkit.org/attachment.cgi?id=216943&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216943&action=review


> Source/WebCore/bindings/objc/DOM.mm:292
> -    return frame->nodeImage(node).get();
> +    return [createDragImageForNode(*frame, node) autorelease];

You need to [[createDragImageForFrameSelection(…) retain] autorelease]. right
now you are over releasing. I am surprised it worked before without a
retain/autorelease.