[webkit-reviews] review granted: [Bug 124359] Make CLoop easier to build, and make it work : [Attachment 216939] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 14 08:31:43 PST 2013
Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 124359: Make CLoop easier to build, and make it work
https://bugs.webkit.org/show_bug.cgi?id=124359
Attachment 216939: Patch
https://bugs.webkit.org/attachment.cgi?id=216939&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216939&action=review
r=me
Please fix stray comment markers.
> Source/JavaScriptCore/jit/JITExceptions.cpp:56
> +// catchRoutine =
vm->getCTIStub(throwNotCaught).code().executableAddress();
Maybe you meant an #ifdef here?
> Source/WTF/wtf/Platform.h:34
> +//#if defined(ENABLE_LLINT_C_LOOP) && ENABLE_LLINT_C_LOOP
Remove comment markers?
More information about the webkit-reviews
mailing list