[webkit-reviews] review granted: [Bug 124350] Web Inspector: Popovers may shrink unnecessarily : [Attachment 216930] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 14 07:21:01 PST 2013
Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 124350: Web Inspector: Popovers may shrink unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=124350
Attachment 216930: Patch
https://bugs.webkit.org/attachment.cgi?id=216930&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review
> Source/WebInspectorUI/UserInterface/Popover.js:402
> + x += containerFrame.maxX() - (x + width);
+= does not sound right. Should this just be =?
> Source/WebInspectorUI/UserInterface/Popover.js:404
> + y += containerFrame.maxY() - (y + height);
Ditto.
More information about the webkit-reviews
mailing list