[webkit-reviews] review granted: [Bug 124338] FontDescription copies should share families list, not duplicate it. : [Attachment 216909] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 124338: FontDescription copies should share families list, not duplicate
it.
https://bugs.webkit.org/show_bug.cgi?id=124338

Attachment 216909: Patch
https://bugs.webkit.org/attachment.cgi?id=216909&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=216909&action=review


> Source/WebCore/platform/graphics/FontDescription.h:235
> +inline bool FontDescription::hasEqualFamilies(const FontDescription& other)
const
> +{
> +    if (m_families.data() == other.m_families.data())
> +	   return true;
> +    if (m_families.size() != other.m_families.size())
> +	   return false;
> +    for (unsigned i = 0; i < m_families.size(); ++i) {
> +	   if (m_families[i] != other.m_families[i])
> +	       return false;
> +    }
> +    return true;
> +}

Seems more like this could be operator== or equals in RefCountedArray