[webkit-reviews] review granted: [Bug 124251] Change callToJavaScript thunk into an offline assembled stub : [Attachment 216836] Patch with fix for windows

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 124251: Change callToJavaScript thunk into an offline assembled stub
https://bugs.webkit.org/show_bug.cgi?id=124251

Attachment 216836: Patch with fix for windows
https://bugs.webkit.org/attachment.cgi?id=216836&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216836&action=review


r=me

Please test on 32bit, 64bit, and Windows before landing.

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:424
> +macro makeCallToJavaScript(entry, newCallFrame, previousCFR)

50% of this function is #ifdef'd, and it is confusingly named synonymously with
doCallToJavaScript. So, I think you should just move the relevant code into the
right places by hand, and remove this helper function.