[webkit-reviews] review requested: [Bug 124167] Make DiskImageCache cross-platform : [Attachment 216830] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 124167: Make DiskImageCache cross-platform
https://bugs.webkit.org/show_bug.cgi?id=124167

Attachment 216830: Patch
https://bugs.webkit.org/attachment.cgi?id=216830&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Thanks for the review, it's very helpful! I did not: a) add the PLATFORM(IOS)
check (doesn't the !PLATFORM(MAC) include IOS?) b) change the hash removal to
take() - when I did that I started getting asserts in some cases because the
entry would have its last ref removed on the last line of
DiskImageCache::Entry::removeFileThreadStart, I guess there's some subtle
interaction between HashMap::take and RefCounted that I did not grasp, any
ideas?