[webkit-reviews] review granted: [Bug 124291] Move provisional load state handling to FrameLoadState : [Attachment 216817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 10:08:16 PST 2013


mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 124291: Move provisional load state handling to FrameLoadState
https://bugs.webkit.org/show_bug.cgi?id=124291

Attachment 216817: Patch
https://bugs.webkit.org/attachment.cgi?id=216817&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216817&action=review


> Source/WebKit2/UIProcess/FrameLoadState.cpp:43
> +    m_loadState = FrameLoadState::LoadStateProvisional;

Why FrameLoadState:: here…

> Source/WebKit2/UIProcess/FrameLoadState.cpp:56
> +    m_loadState = LoadStateFinished;

…but not here?


More information about the webkit-reviews mailing list