[webkit-reviews] review granted: [Bug 124199] Fixed unused parameter warnings in WebCore : [Attachment 216788] Patch v7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 03:51:10 PST 2013


Csaba Osztrogonac <ossy at webkit.org> has granted Tibor Mészáros
<mtibor at inf.u-szeged.hu>'s request for review:
Bug 124199: Fixed unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124199

Attachment 216788: Patch v7
https://bugs.webkit.org/attachment.cgi?id=216788&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216788&action=review


LGTM, r=me. I'll fix the style issue mentioned before landing.

> Source/WebCore/platform/graphics/WidthIterator.cpp:134
> +#else
> +	   UNUSED_PARAM(iterator);
>  #endif
>	   fontData->applyTransforms(glyphBuffer->glyphs(lastGlyphCount),
advances + lastGlyphCount, glyphBufferSize - lastGlyphCount,
typesettingFeatures);

This code is so ugly ... :-/

Maybe we should reorder it a little bit:
#if !ENABLE(SVG_FONTS)
     UNUSED_PARAM(iterator);
#else
    // We need to handle transforms on SVG fonts internally, since they are
rendered internally.
    if 
    ....
    } else
#endif
	fontdata->applyTransforms(...);


More information about the webkit-reviews mailing list