[webkit-reviews] review requested: [Bug 121415] The size of the background colour is not properly adjusted when the font size is being changed : [Attachment 216786] Solution enhancement for the font size change and backgroundcolor issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 13 03:08:52 PST 2013


Artur Moryc <a.moryc at samsung.com> has asked  for review:
Bug 121415: The size of the background colour is not properly adjusted when the
font size is being changed
https://bugs.webkit.org/show_bug.cgi?id=121415

Attachment 216786: Solution enhancement for the font size change and
backgroundcolor issue
https://bugs.webkit.org/attachment.cgi?id=216786&action=review

------- Additional Comments from Artur Moryc <a.moryc at samsung.com>
Thank you very much for very comprehensive comments and explanations to the
previous patches.  
In this patch background color is added to the font tag inline. However, still
there are two things that can be pointed out:
1) As it can be seen in the attach chart there is still no difference between
the small and normal font size. It happens since the span tag with style
background color may overwrite the background color for the font tag with small
size font (please have a look at the attached chart) 
2) After adding a text with default font size it results in that next nodes
with different font sizes are added as child nodes. It also may influence on
overwriting the beckgroundcolor for small font size.


More information about the webkit-reviews mailing list