[webkit-reviews] review denied: [Bug 124199] Fixed unused parameter warnings in WebCore : [Attachment 216691] Patch v6

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied Tibor Mészáros
<mtibor at inf.u-szeged.hu>'s request for review:
Bug 124199: Fixed unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124199

Attachment 216691: Patch v6
https://bugs.webkit.org/attachment.cgi?id=216691&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216691&action=review


LGTM in general, but r- now due to style issues, please fix them.

> Source/WebCore/css/CSSCursorImageValue.cpp:178
> +#else
> +	   UNUSED_PARAM(document);

wrong indentation here too

> Source/WebCore/dom/Document.cpp:4874
> +#else
> +	   UNUSED_PARAM(isThrottled);

ditto

> Source/WebCore/loader/DocumentThreadableLoader.cpp:335
> +	   UNUSED_PARAM(identifier);

ditto

> Source/WebCore/loader/DocumentThreadableLoader.cpp:361
> +	   UNUSED_PARAM(identifier);

ditto

> Source/WebCore/rendering/style/RenderStyle.cpp:793
> +	   UNUSED_PARAM(other);

ditto