[webkit-reviews] review granted: [Bug 124246] Web Inspector: Extract InspectorFrontendDispatchers from InspectorFrontend : [Attachment 216748] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 124246: Web Inspector: Extract InspectorFrontendDispatchers from
InspectorFrontend
https://bugs.webkit.org/show_bug.cgi?id=124246

Attachment 216748: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=216748&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216748&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.py:1904
> +		       domainClassName="Inspector%sFrontendDispatcher" %
domain_name,
> +		      
frontendDomainMethodDeclarations="".join(flatten_list(frontend_method_declarati
on_lines))))

Should add spaces around the assignment = while you are touching this horrid
code. Should do a find and replace globally at some point… or just find a way
to rm *.py someday. :P

> Source/WebCore/inspector/InspectorCSSAgent.cpp:695
> -    m_frontend->namedFlowCreated(buildObjectForNamedFlow(&errorString,
namedFlow, documentNodeId));
> +   
m_frontendDispatcher->namedFlowCreated(buildObjectForNamedFlow(&errorString,
namedFlow, documentNodeId));

Oh how much a single word helps.

> Source/WebCore/inspector/InspectorDOMStorageAgent.h:84
> -    InspectorFrontend* m_frontend;
> +    std::unique_ptr<InspectorDOMStorageFrontendDispatcher>
m_frontendDispatcher;

And at last I see the light! It's like the fog has lifted.

> Source/WebCore/inspector/InspectorWorkerAgent.cpp:131
> +    disable(nullptr);

Can disable() default errorString to nullptr? This looks funny to me.