[webkit-reviews] review granted: [Bug 124252] [Mac] Fix some deprecation warnings : [Attachment 216752] [Mac] Fix some deprecation warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 17:53:59 PST 2013


Mark Rowe (bdash) <mrowe at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 124252: [Mac] Fix some deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=124252

Attachment 216752: [Mac] Fix some deprecation warnings
https://bugs.webkit.org/attachment.cgi?id=216752&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216752&action=review


> Source/WebCore/platform/mac/HTMLConverter.mm:1536
> +    dateComponents.get().timeZone = [NSTimeZone
timeZoneForSecondsFromGMT:0];

I think it's conventional to do [dateComponents setTimeZone:…]; rather than
calling .get() just to use the property syntax. Similarly for the use of
getters below.


More information about the webkit-reviews mailing list