[webkit-reviews] review denied: [Bug 124238] Add comment to FrameView::doLayoutWithFrameFlattening() to clear up the meaning of the bool return value. : [Attachment 216734] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 15:49:01 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 124238: Add comment to FrameView::doLayoutWithFrameFlattening() to clear up
the meaning of the bool return value.
https://bugs.webkit.org/show_bug.cgi?id=124238

Attachment 216734: Patch
https://bugs.webkit.org/attachment.cgi?id=216734&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
The header file should have the "Return true if the layout got re-initiated and
this view needs no layout anymore." comment just above the function
declaration, perhaps worded in a way that makes more sense with less context.


More information about the webkit-reviews mailing list