[webkit-reviews] review granted: [Bug 124237] Move ValueToString out to its own header file to remove duplication : [Attachment 216732] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 124237: Move ValueToString out to its own header file to remove duplication
https://bugs.webkit.org/show_bug.cgi?id=124237

Attachment 216732: Patch
https://bugs.webkit.org/attachment.cgi?id=216732&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216732&action=review


r=me

> Source/WebCore/platform/LayoutUnit.h:34
> +#ifndef NDEBUG

nit: You don't need the #ifndef here. The file itself already has it. Also, you
don't do that in the other headers.

> Source/WebCore/platform/LayoutUnit.h:970
> +template <> struct ValueToString<LayoutUnit> {

nit: you have different styles for the template<> placement. I think the second
one is better.

template <> struct ValueToString<LayoutUnit>

and 

template <>
struct ValueToString<LayoutUnit>