[webkit-reviews] review denied: [Bug 124180] GStreamer source files should be included in Windows build : [Attachment 216630] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 124180: GStreamer source files should be included in Windows build
https://bugs.webkit.org/show_bug.cgi?id=124180

Attachment 216630: Patch
https://bugs.webkit.org/attachment.cgi?id=216630&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216630&action=review


This seems fine, but please exclude them from the Apple port build to reduce
confusion.

> Source/WTF/WTF.vcxproj/WTF.vcxproj:78
> +    <ClCompile Include="..\wtf\gobject\GRefPtr.cpp" />

These need to be marked as "don't build" on non-WinCairo ports.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7261
> +    <ClCompile
Include="..\platform\graphics\gstreamer\WebKitWebSourceGStreamer.cpp" />

These should be excluded as well.  I know that they don't compile due to the
USE(GSTREAMER) guards, but it might confuse someone who thinks GStreamer is
being used under the Apple port.