[webkit-reviews] review granted: [Bug 124193] Introduce IDBServerConnection (and start moving things to it) : [Attachment 216648] Patch v3

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 124193: Introduce IDBServerConnection (and start moving things to it)
https://bugs.webkit.org/show_bug.cgi?id=124193

Attachment 216648: Patch v3
https://bugs.webkit.org/attachment.cgi?id=216648&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216648&action=review


> Source/WebCore/Modules/indexeddb/IDBServerConnection.h:40
> +// This interface is meant to provide a single asynchronous layer between
the web-facing frontend

Does it provide what it means to provide? The comment should either be more
assertive, or a specific FIXME.

> Source/WebCore/Modules/indexeddb/IDBServerConnection.h:42
> +// If the completion of an operation is important monitoring it must be
through the use of a callback function.

Important?

> Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:29
> +#include "IDBBackingStoreInterface.h"

Is there a reason why this is outside ifdefs?

We usually put headers inside ifdefs in cpp files, and outside ifdefs in
headers.