[webkit-reviews] review denied: [Bug 118665] [CSS Regions] Implement visual overflow for first & last regions : [Attachment 216380] Patch (src only, will add tests in a separate attachment, for easier review).

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 118665: [CSS Regions] Implement visual overflow for first & last regions
https://bugs.webkit.org/show_bug.cgi?id=118665

Attachment 216380: Patch (src only, will add tests in a separate attachment,
for easier review).
https://bugs.webkit.org/attachment.cgi?id=216380&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch looks like it is breaking overflow for multicolumn, so that's the
reason for the minus. Your options are basically to try to preserve the
original behavior, or to just make the change to actually do overflow for
columns. Columns were basically using the flow thread overflow and intersecting
that with a rect that extended halfway into the column gap for interior
columns. The repaintFlowThreadContentRectangle handled this, since you could
pass in an overflow rect for repainting and have the right thing happen.

If you decide you really want to try to do visual overflow for columns, the
tricky bit is that each column needs a RenderOverflow, and not just the single
RenderMultiColumnSet as a whole. The overflow portion rect in the flow thread
is the same as per a region with the addition of the "clip halfway into the
column gap" rule for interior edges (so first and last column don't have their
exterior edges clipped).

I'm fine with overflow not being implemented for columns as long as you don't
break it though.