[webkit-reviews] review granted: [Bug 124208] Begin cleaning up handling of ImmutableArray vectors : [Attachment 216683] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 12 09:21:57 PST 2013


Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 124208: Begin cleaning up handling of ImmutableArray vectors
https://bugs.webkit.org/show_bug.cgi?id=124208

Attachment 216683: Patch
https://bugs.webkit.org/attachment.cgi?id=216683&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216683&action=review


r=me

> Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp:122
> +	   hostnameStrings.append(WebString::create(hostname));

I thought this was supposed to be uncheckedAppend(). Is this intentional? Why
aren't you using uncheckedAppend() here?


More information about the webkit-reviews mailing list