[webkit-reviews] review granted: [Bug 123439] Fix reported build warnings for GTK : [Attachment 216668] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 12 06:54:04 PST 2013
Carlos Garcia Campos <cgarcia at igalia.com> has granted Tibor Mészáros
<mtibor at inf.u-szeged.hu>'s request for review:
Bug 123439: Fix reported build warnings for GTK
https://bugs.webkit.org/show_bug.cgi?id=123439
Attachment 216668: Patch v2
https://bugs.webkit.org/attachment.cgi?id=216668&action=review
------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216668&action=review
Thanks for the patch, there are a couple of problems with the ChangeLog.
> Source/WebCore/ChangeLog:3
> + There was a void method, that has return value in it's
documentation, so I removed it.
This line should contain the bug title, add your explanation below, after the
Reviewed by line.
> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).
You should remove this line about the new tests.
More information about the webkit-reviews
mailing list