[webkit-reviews] review denied: [Bug 124178] Start moving off of NSCalendarDate : [Attachment 216641] This time, =?UTF-8?Q?=20don=E2=80=99t=20modify=20API?=.

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 124178: Start moving off of NSCalendarDate
https://bugs.webkit.org/show_bug.cgi?id=124178

Attachment 216641: This time, don’t modify API.
https://bugs.webkit.org/attachment.cgi?id=216641&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216641&action=review


> Source/WebKit/mac/History/WebHistory.h:131
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>  - (NSArray *)orderedItemsLastVisitedOnDay:(NSCalendarDate *)calendarDate;
> +#pragma clang diagnostic pop

We can't disable deprecation warnings in public headers!