[webkit-reviews] review granted: [Bug 124183] Make IDBTransaction tasks asynchronous : [Attachment 216632] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 124183: Make IDBTransaction tasks asynchronous
https://bugs.webkit.org/show_bug.cgi?id=124183

Attachment 216632: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=216632&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216632&action=review


> Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp:44
> +class CallbackCaller {

I feel like there's a name for this.

> Source/WebCore/Modules/indexeddb/IDBOperation.h:29
> +#include <Functional>

capital F, really?

> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:245
> +    // Take take a self reference to keep this object alive so that tasks
can

Take take

> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:254
> +	   {

not sure if this belongs here or on the previous line.

> Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:41
> +class CallbackCaller {

déjà vu?

> Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:382
> +void
IDBDatabaseBackend::VersionChangeOperation::perform(std::function<void()>
completionCallback)

Wonder if your std::function deserves a typedef too.