[webkit-reviews] review canceled: [Bug 124172] Support unprefixed deconstructing assignment : [Attachment 216624] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has canceled Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 124172: Support unprefixed deconstructing assignment
https://bugs.webkit.org/show_bug.cgi?id=124172

Attachment 216624: Patch
https://bugs.webkit.org/attachment.cgi?id=216624&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216624&action=review


Can you please address the comments below?

> Source/JavaScriptCore/ChangeLog:15
> +	   We're also able to predicate our attempt to parse on the existence
of
> +	   '[' or '{' as they not as common as other constructs. 

typo: they *are* not

> Source/JavaScriptCore/parser/Parser.cpp:430
> +    SavePoint start = createSavePoint();

Isn't this redundant?  The 2 caller sites that uses
tryParseDeconstructionPatternExpression() also save a SavePoint.

> LayoutTests/js/script-tests/parser-syntax-check.js:391
> +valid("for ({of} in of){}")

The expected results said that this test FAILed.  This suggests that either
this test should expect the statement to be "invalid" or the FAIL results are
indicating there's a bug.  Can you please clarify which it's supposed to be?

> LayoutTests/js/script-tests/parser-syntax-check.js:430
> +valid("var {x: 1}=1")
> +valid("[x]=1)")

Ditto with FAILed results.