[webkit-reviews] review granted: [Bug 124078] Web Inspector: Crash when closing the Inspector while debugging an exception inside a breakpoint condition. : [Attachment 216619] Patch V1

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 124078: Web Inspector: Crash when closing the Inspector while debugging an
exception inside a breakpoint condition.
https://bugs.webkit.org/show_bug.cgi?id=124078

Attachment 216619: Patch V1
https://bugs.webkit.org/attachment.cgi?id=216619&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216619&action=review


r=me, nice!

>
LayoutTests/inspector-protocol/debugger/breakpoint-action-with-exception.html:4
7
> +    function completeTest()
> +    {
> +	   // Reset the pauseOnException state before ending the test.
> +	   InspectorTest.sendCommand("Debugger.setPauseOnExceptions", {state:
"none"});
> +	   InspectorTest.completeTest();
> +    }

Ideally DumpRenderTree could enforce a clean slate before running each test.
But this is good for now.