[webkit-reviews] review granted: [Bug 124056] Make RenderBlockRareData into a hash. : [Attachment 216591] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 124056: Make RenderBlockRareData into a hash.
https://bugs.webkit.org/show_bug.cgi?id=124056

Attachment 216591: Patch
https://bugs.webkit.org/attachment.cgi?id=216591&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216591&action=review


> Source/WebCore/rendering/RenderBlock.cpp:225
> +    if (hasRareData())
> +	   gRareDataMap->take(this);

I’d just do an if (g_rareDataMap) g_rareDataMap->remove(this) here to avoid two
hash lookups (one for the hasRareData and another for the actual remove).

> Source/WebCore/rendering/RenderBlock.cpp:1416
> +static RenderBlockRareData* ensureRareData(const RenderBlock* block)

I think this should return a reference since it can never be null.