[webkit-reviews] review granted: [Bug 124056] Make RenderBlockRareData into a hash. : [Attachment 216587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 11 10:34:34 PST 2013


Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 124056: Make RenderBlockRareData into a hash.
https://bugs.webkit.org/show_bug.cgi?id=124056

Attachment 216587: Patch
https://bugs.webkit.org/attachment.cgi?id=216587&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216587&action=review


> Source/WebCore/rendering/RenderBlock.cpp:129
> +typedef WTF::HashMap<const RenderBlock*, OwnPtr<RenderBlockRareData>>
RenderBlockRareDataMap;

I would remove the WTF:: from HashMap (its not needed) and make it a
std::unique_ptr<RenderBlockRareData>.


More information about the webkit-reviews mailing list