[webkit-reviews] review denied: [Bug 124149] Build fail on CPU(ARM_TRADITIONAL) after r159039 : [Attachment 216575] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 11 08:58:03 PST 2013
Geoffrey Garen <ggaren at apple.com> has denied Gabor Rapcsanyi
<rgabor at webkit.org>'s request for review:
Bug 124149: Build fail on CPU(ARM_TRADITIONAL) after r159039
https://bugs.webkit.org/show_bug.cgi?id=124149
Attachment 216575: proposed fix
https://bugs.webkit.org/attachment.cgi?id=216575&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
It looks like this change will cut back the ARMv7Assembler from max register
r15 to max register r13, since ARMv7Assembler::lastRegister() returns r13.
Is that the right thing to do? Your ChangeLog doesn't explain why you did it,
or why it's right.
Regardless of whether it's right, it's bad for a build fix patch on one
platform to include a behavior change on another platform. They should be two
separate patches.
More information about the webkit-reviews
mailing list