[webkit-reviews] review granted: [Bug 123944] Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache : [Attachment 216416] accidental SPI

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 123944: Remote Layer Tree: RemoteLayerBackingStore partial repaint is
broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944

Attachment 216416: accidental SPI
https://bugs.webkit.org/attachment.cgi?id=216416&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216416&action=review


> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * platform/graphics/ca/PlatformCALayer.h:

High level summary please!

> Source/WebCore/ChangeLog:30
> +	   has at least one layer in it (appending the clip bounds if we don't

one rect?

> Source/WebCore/platform/graphics/mac/WebLayer.mm:112
> +	   graphicsContext.clip(rect);

In the one-rect case you're clipping here where you didn't before, but that's
probably OK.