[webkit-reviews] review granted: [Bug 124084] getCueAsHTML() on an empty cue should return a document fragment : [Attachment 216463] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 124084: getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084

Attachment 216463: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=216463&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review


> Source/WebCore/html/track/WebVTTParser.cpp:356
> +    if (!text.length()) {

Normally we’d use isEmpty here instead.