[webkit-reviews] review granted: [Bug 123769] [CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped : [Attachment 216315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 13:59:03 PST 2013


Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 123769: [CSS Shapes] Image valued shape-outside that extends vertically
into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769

Attachment 216315: Patch
https://bugs.webkit.org/attachment.cgi?id=216315&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216315&action=review


r=me Looks like the patch does not apply anymore though.

>
LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-
004-expected.html:6
> +	   font: 25px/1 Ahem, sans-serif;

Snippet , but it looks weird to have 25px/1, could you add spaces please? :)
Ditto for the others.


More information about the webkit-reviews mailing list