[webkit-reviews] review granted: [Bug 123931] RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode : [Attachment 216426] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 123931: RenderBlockFlow::nextFloatLogicalBottomBelow should not use
ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931

Attachment 216426: Patch
https://bugs.webkit.org/attachment.cgi?id=216426&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216426&action=review


> Source/WebCore/rendering/FloatingObjects.cpp:159
> +    FindNextFloatLogicalBottomAdapter(const RenderBlockFlow* renderer,
LayoutUnit belowLogicalHeight)

You should take the RenderBlockFlow by reference.

> Source/WebCore/rendering/FloatingObjects.cpp:176
> +    const RenderBlockFlow* m_renderer;

This should be a reference.