[webkit-reviews] review granted: [Bug 124053] JSManagedValue should automatically call removeManagedReference:withOwner: upon dealloc : [Attachment 216414] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 124053: JSManagedValue should automatically call
removeManagedReference:withOwner: upon dealloc
https://bugs.webkit.org/show_bug.cgi?id=124053

Attachment 216414: Patch
https://bugs.webkit.org/attachment.cgi?id=216414&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216414&action=review


r=me, pending those things.

> Source/JavaScriptCore/API/JSManagedValue.h:58
> ++ (JSManagedValue *)managedValueWithValue:(JSValue *)value
andOwner:(id)owner;

It looks like the canonical ObjC API idiom is to leave off "and". For example,
-[NSString – initWithBytes:length:encoding:].