[webkit-reviews] review denied: [Bug 123333] [curl] Add file cache : [Attachment 216378] Proposed patch 2

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Mátyás Mustoha
<mmatyas at inf.u-szeged.hu>'s request for review:
Bug 123333: [curl] Add file cache
https://bugs.webkit.org/show_bug.cgi?id=123333

Attachment 216378: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=216378&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216378&action=review


This is looking really good!  I had a couple of more minor things, then I think
we're ready to land this.  Thanks for doing this work!

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:105
> +bool CurlCacheEntry::loadCachedData(ResourceHandle *job)

ResourceHandle* please.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:165
> +void CurlCacheEntry::setResponseFromCachedHeaders(ResourceResponse
&response)

ResourceResponse& please.

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:326
> +

DOn't need this line.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:158
> +	   CString urlLatin1 = it->key.latin1();

This is making a copy.	I think you could use a const reference to avoid that.