[webkit-reviews] review denied: [Bug 68512] [ATK] Tests failing due to not properly considering flattened text objects : [Attachment 216402] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Lukasz Gajowy
<l.gajowy at samsung.com>'s request for review:
Bug 68512: [ATK] Tests failing due to not properly considering flattened text
objects
https://bugs.webkit.org/show_bug.cgi?id=68512

Attachment 216402: Patch 
https://bugs.webkit.org/attachment.cgi?id=216402&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216402&action=review


looks pretty good, but some comments inside

> LayoutTests/accessibility/secure-textfield-title-ui.html:25
> +	       debug("titleText.stringValue is: " + titleText.stringValue);

this has a 5 character indent

> LayoutTests/accessibility/text-role-with-aria-hidden-inside.html:25
> +	   debug("text.stringValue is: " + text.stringValue);

why can't this be run on gtk or efl? and if that's the case we could leave this
as a should be

> LayoutTests/platform/efl/accessibility/render-counter-text-expected.txt:5
> +line1.childAtIndex(0).stringValue is:

is stringValue not implemented on efl? seems like we should continue to mark as
failure until that's done (since this test isn't really testing anything right
now seemingly)