[webkit-reviews] review granted: [Bug 122801] [GTK] [WebKit2] Crash when printing to a file via javascript : [Attachment 216392] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 122801: [GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801

Attachment 216392: Patch
https://bugs.webkit.org/attachment.cgi?id=216392&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216392&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:233
> +    if (!priv->printSettings)
> +	   priv->printSettings = adoptGRef(gtk_print_settings_new());
> +    gtk_print_unix_dialog_set_settings(printDialog,
priv->printSettings.get());

Okay. Do you mind putting a comment here with a link to the GTK+ bug and a
small bit explaining what's going on. I think it will be nice to have if we
ever bump the GTK+ requirement, so that we can remove the work-around.