[webkit-reviews] review requested: [Bug 123333] [curl] Add file cache : [Attachment 216378] Proposed patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 8 05:35:23 PST 2013


Mátyás Mustoha <mmatyas at inf.u-szeged.hu> has asked  for review:
Bug 123333: [curl] Add file cache
https://bugs.webkit.org/show_bug.cgi?id=123333

Attachment 216378: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=216378&action=review

------- Additional Comments from Mátyás Mustoha <mmatyas at inf.u-szeged.hu>
Thanks for the detailed review! I fixed the issues you've mentioned.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:90
> +    long long filesize = -1;

I've used "long long" because getFileSize() in FileSystem.h expects a long long
variable as parameter:
bool getFileSize(const String&, long long& result);


More information about the webkit-reviews mailing list