[webkit-reviews] review granted: [Bug 124032] [AX] Clean up static_cast<> to cast from AccessibilityObject : [Attachment 216361] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 124032: [AX] Clean up static_cast<> to cast from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=124032

Attachment 216361: Patch
https://bugs.webkit.org/attachment.cgi?id=216361&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=216361&action=review


(In reply to comment #3)
> Mario, how do you think ?

I think it's a good cleanup. Setting the r+ now, but please fix those small
things pointed out below before landing. Thanks!

> Source/WebCore/accessibility/AccessibilityListBoxOption.h:65
> -    bool isListBoxOption() const { return true; }
> +    bool isListBoxOption() const OVERRIDE { return true; }

You should declare it as virtual and use the FINAL modifier here too if you are
declaring this in upper classes as a virtual method (as you are)

> Source/WebCore/accessibility/AccessibilitySlider.h:75
> +    virtual bool isSliderThumb() const OVERRIDE { return true; }

FINAL missing