[webkit-reviews] review denied: [Bug 123891] [arm] Crashes due to ASSERTION FAILED in JSC::ARMAssembler::getLdrImmAddress : [Attachment 216294] Use specific implementation of PatchableJump for CPU(ARM_TRADITIONAL)

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has denied Julien Brianceau
<jbriance at cisco.com>'s request for review:
Bug 123891: [arm] Crashes due to ASSERTION FAILED in
JSC::ARMAssembler::getLdrImmAddress
https://bugs.webkit.org/show_bug.cgi?id=123891

Attachment 216294: Use specific implementation of PatchableJump for
CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/attachment.cgi?id=216294&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216294&action=review


> Source/JavaScriptCore/jit/GPRInfo.h:-469
> -	   ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);

Why don't we need this static_cast, InvalidGPRReg is an unsigned value that
uses the full 32 bits.

> Source/JavaScriptCore/jit/GPRInfo.h:-479
> -	   ASSERT(static_cast<unsigned>(reg) != InvalidGPRReg);

Ditto